Add a table of system dependencies with minimum versions #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This documents and enforces minimum requirements for C library dependencies. At the moment versions were picked from debian bookworm (debian stable since 2023-06), except blkid (util-linux) where 2.40.1 is required: koverstreet#347 libaio is excluded because it doesn't provide a pkg-config file. Also remove libscrypt from debian/control since we use the libsodium implementation.
|
Can someone with nix fu require blkid 2.40.1 in flake.nix? Edit: actually it needs to be updated in nixpkgs: |
|
Currently blocked on NixOS/nixpkgs#333467 |
2.40.1 is still a soft requirement as format will refuse to run without a flag. nixpkgs requiring macOS compatibility of util-linux is a questionable choice. See: - NixOS/nixpkgs#333467 - util-linux/util-linux#3013 Rationale for picking blkid 2.39.3: https://mirrors.edge.kernel.org/pub/linux/utils/util-linux/v2.39/v2.39.3-ReleaseNotes
|
Worked around by lowering the blkid requirement to something nixpkgs has. There's still a safeguard against actually formatting using an outdated blkid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents and enforces minimum requirements for C library dependencies. At the moment versions were picked from debian bookworm (debian stable since 2023-06), except blkid (util-linux) where 2.40.1 is required: #347
libaio is excluded because it doesn't provide a pkg-config file.
Also remove libscrypt from debian/control since we use the libsodium implementation.