Rust dependency cleanups and minimum requirements #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the minimum versions so the source compiles.
Verified with:
cargo +nightly update -Zminimal-versions --offline --verbose
cargo update -p regex-syntax --precise=0.6.25
cargo check
bch_bindgen -> bindgen already requires bitflags 2, so this can eliminate a duplicate dependency.
No impact. We could also pick the 0.2-0.3 range to help distributions, but debian already has 0.3. We already require errno 0.3 through rustix, so this can eliminate a duplicate dependency.
Found with cargo-machete.
g2p
force-pushed
the
dependency-cleanups
branch
from
74bc629
to
c749ce9
Compare
|
Ping? This will be useful for packagers |
g2p
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a handful of clean ups to the Cargo.toml
Most important is to correctly specify minimal dependencies.
Also upgrade two outdated dependencies when we already require the newer versions indirectly.