fix(subvol): make cmds work with relative paths #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Path::parent()` returns `Some("")` for relative paths with a single
component. The simplest fix is to just canonicalize the paths first.
Signed-off-by: Thomas Mühlbacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path::parent()returnsSome("")for relative paths with a single component. The simplest fix is to just canonicalize the paths first.So I actually had a few misconceptions about this issue, at first I thought it
was because I was doing
bcachefs subvolume create my-subvolwithin a bindmount because it worked when I gave the absolute path from the real mount. Then
I thought it was about
CStringlifetime in FFI, which was also incorrect.In the end it's pretty simple. The
Path::parent()API doesn't take intoaccount any side effects from the file system or check the real path. It just
works on the bytes of the
Pathand gives us a slice into thePath.