Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add passphrase_file to mount options (refactored) #269

Closed
wants to merge 4 commits into from
Closed

Add passphrase_file to mount options (refactored) #269

wants to merge 4 commits into from

Conversation

RlndVt
Copy link

@RlndVt RlndVt commented May 18, 2024

Expansion of @donmor's work in #266

@donmor
Copy link

donmor commented May 18, 2024

Reviewed. Now we may take a break and wait for any of our PRs to get merged :)

@JohnRTitor
Copy link

@RlndVt could you rebase this?

@RlndVt
Copy link
Author

RlndVt commented Jun 2, 2024

Thanks for the heads up, I've started looking into it.

@RlndVt RlndVt force-pushed the feature/passphrasefile_as_mount_option branch from 64b9941 to a6f7415 Compare June 3, 2024 11:40
RlndVt
RlndVt commented Jun 3, 2024
View reviewed changes
src/commands/mount.rs Outdated
}
)
// Unlock by unlock policy
.unwrap_or_else(|| unlock_policy.apply(&first_sb)))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not completely happy with this flow yet.

The opening bracket on 389 matches the last closing bracket at the end of this line (402). Preferably I would close it on line 400, but haven't figured out how to get the types matched up quite yet.

@RlndVt RlndVt marked this pull request as draft June 3, 2024 11:59
@RlndVt RlndVt marked this pull request as ready for review June 3, 2024 19:23
JohnRTitor
JohnRTitor reviewed Jun 3, 2024
View reviewed changes
Copy link

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks are failing, please have a look.

@RlndVt
Copy link
Author

RlndVt commented Jun 4, 2024

I'm not sure I understand the failing check; I believe "treefmt-check" is unhappy with the format of the code?

@RlndVt RlndVt force-pushed the feature/passphrasefile_as_mount_option branch 2 times, most recently from 6ba6911 to e985349 Compare June 4, 2024 18:15
@RlndVt RlndVt force-pushed the feature/passphrasefile_as_mount_option branch 6 times, most recently from 3657c77 to ca82ea4 Compare June 4, 2024 18:48
@donmor @RlndVt
Add -o passphrase_file= mount option.
344cfc3 
Is handled after the cli passphrase_file option.
Allows unlocking the volume in fstab.
@RlndVt RlndVt force-pushed the feature/passphrasefile_as_mount_option branch 3 times, most recently from a43556e to 995de4b Compare June 4, 2024 19:01
@RlndVt RlndVt force-pushed the feature/passphrasefile_as_mount_option branch from 995de4b to f7ea066 Compare June 4, 2024 19:03
@RlndVt
Copy link
Author

RlndVt commented Jun 4, 2024

Sorry for the force-push spam. treefmt-check is a fickle beast.

@RlndVt RlndVt requested a review from JohnRTitor June 4, 2024 19:07
JohnRTitor
JohnRTitor reviewed Jun 4, 2024
View reviewed changes
Copy link

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but @koverstreet should take a look.

@RlndVt
Copy link
Author

RlndVt commented Jun 5, 2024

In response to asking Kent to take a look:

On 19/05/2024 18:33, Kent Overstreet [email protected] wrote:

I'm still catching up from conferences, but - it's not my preferred
approach since it's easy to misuse, I know there's legitimate use cases
but this makes it particularly easy for users to dumb things and leave
their systems easy to compromise.

Could you chat with Tony about other options? There's a couple (safer)
things we still need, perhaps one of them will do what you need.

On Wednesday, June 5th, 2024 at 3:04 PM, Kent Overstreet [email protected] wrote:

I'm not going to merge this; I've seen plenty of suggesteniosn for
alternative workflows elsewhere.

I've asked (him and Tony) what the other options/alternative workflows are but no response yet.

Conclusion for this PR is still the same: won't be merged. Same (most likely) goes for #266.

@RlndVt RlndVt closed this Jun 5, 2024
@RlndVt
Copy link
Author

RlndVt commented Jul 26, 2024

A gist on how I mount my encrypted array at boot:

https://gist.github.com/RlndVt/7055be264c9492064d3523c8e74ea0a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnRTitor JohnRTitor JohnRTitor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RlndVt @donmor @JohnRTitor