Remove udev from PKGCONFIG_LIBS in Makefile

libudev.pc is the pkg-config file for the udev libraries. udev.pc is just there to define the directory that rules etc. should be installed into. It therefore doesn't need to be included in the list of libraries passed to pkg-config --cflags or pkg-config --libs. At least one implementation of the libudev API, libudev-zero, does not provide a udev.pc file, because it does not implement the udev rules language, just the library API. With this change, it's possible to build bcachefs-tools against libudev-zero by pointing PKGCONFIG_UDEVDIR somewhere on the make command line. Signed-off-by: Alyssa Ross <[email protected]> Signed-off-by: Kent Overstreet <[email protected]>
koverstreet · Sep 4, 2024 · f9ec00d · f9ec00d
1 parent 68704c3
commit f9ec00d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/Makefile b/Makefile
@@ -74,7 +74,7 @@ CFLAGS+=$(call cc-disable-warning, shift-overflow)
 CFLAGS+=$(call cc-disable-warning, enum-conversion)
 CFLAGS+=$(call cc-disable-warning, gnu-variable-sized-type-not-at-end)
 
-PKGCONFIG_LIBS="blkid uuid liburcu libsodium zlib liblz4 libzstd libudev libkeyutils udev"
+PKGCONFIG_LIBS="blkid uuid liburcu libsodium zlib liblz4 libzstd libudev libkeyutils"
 ifdef BCACHEFS_FUSE
 	PKGCONFIG_LIBS+="fuse3 >= 3.7"
 	CFLAGS+=-DBCACHEFS_FUSE