Replace sha1 dependency with sha-1 #231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This other crate is being maintained, and it offers better performances when using the `asm` feature (especially [on AArch64](RustCrypto/hashes#97)). Once websockets-rs/rust-websocket#251 is merged, it will also allow removing this extra crate from the build.
Author
|
With sha1 being the new upstream of sha-1, this change shouldn’t get merged any more, instead we should update sha1 to its 0.10 version. |
Author
|
This project seems abandoned, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This other crate is being maintained, and it offers better performances when using the
asmfeature (especially on AArch64).Once websockets-rs/rust-websocket#251 is merged, it will also allow removing this extra crate from the build.