homekit: Added Common Humidifer/Dehumidifer Settings to Thermostat and Fans #1699
+196
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to expose settings Home Assistant
koush
reviewed
Jan 21, 2025
| return service; | ||
| } | ||
|
|
||
| export function addDehumidifer(device: ScryptedDevice & HumiditySetting & HumiditySensor, accessory: Accessory): Service { |
koush
reviewed
Jan 21, 2025
| return service; | ||
| } | ||
|
|
||
| export function addHumidifier(device: ScryptedDevice & HumiditySetting & HumiditySensor, accessory: Accessory): Service { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using Scrypted to pull my thermostat settings into Home Assistant via the HomeKit Controller and noticed that they require the following characteristics to be set to show the
Fan ModeandHumiditysettings on their climate card.Characteristic.TargetFanStateas seen here to enable Fan Modes.Characteristic.CurrentFanStateas seen here to indicate if the fan is activeCharacteristic.TargetRelativeHumidityas seen here to enable Humidity card.Characteristic.CurrentRelativeHumidityas seen here to indicate humidity to card.I also took the opportunity to move the humidity settings to a common setup method for both
ThermostatandFan/