-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scopes-closures/ch2 translation #28
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Please see my comments below. Also, please check formatting of code pieces in text: in many places there are redundant white spaces not present in initial text, like so: getStudentName (..)
|
||
## Marbles, and Buckets, and Bubbles... Oh My! | ||
Цей розділ проілюструє _області видимості_ кількома метафорами. Головна мета:_обдумати_ як обробляється ваша програма за допомогою рушія JS таким чином, щоб ближче відповідати тому, як насправді працює рушій JS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea here is that our thinking about the programs must be more alike to how the engine actually treats them. I'm referring to "щоб ближче відповідати тому": what is phrase related to?
|
||
One metaphor I've found effective in understanding scope is sorting colored marbles into buckets of their matching color. | ||
## Кульки, і Відра, і Оболонки ... Ой, лишенько! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why uppercase?
|
||
This chapter will illustrate *scope* with several metaphors. The goal here is to *think* about how your program is handled by the JS engine in ways that more closely align with how the JS engine actually works. | ||
Згадаємо свій шкільний математичний клас: недостатньо отримати правильну відповідь без наявності ходу власних думок! У нашому випадку потрібно будувати точні та корисні розумові моделі,щоб рухатись вперед. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing whitespace: "моделі,щоб "
|
||
The error message for an undeclared variable condition, in most JS environments, will look like, "Reference Error: XYZ is not defined." The phrase "not defined" seems almost identical to the word "undefined," as far as the English language goes. But these two are very different in JS, and this error message unfortunately creates a persistent confusion. | ||
Повідомлення про помилку для незадекларованої умови змінної у більшості середовищ JS буде виглядати так: "Помилка посилання: XYZ не визначено". Фраза "не визначено" здається майже ідентичною слову "невизначений", що стосується англійської мови. Але ці двоє дуже різні в JS, і це повідомлення про помилку, на жаль, створює стійке непорозуміння. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave the error text untranslated or translated in parentheses additionally to English text
|
||
One metaphor I've found effective in understanding scope is sorting colored marbles into buckets of their matching color. | ||
## Кульки, і Відра, і Оболонки ... Ой, лишенько! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "кошик"? I know it's not and exact translation of "bucket", but "Відра" as a metaphor sound unclear in Ukrainian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, it sounds much better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case (use word "кошик") I propose to change translation in Book 1 as well (вiдерця -> кошики) to be more consistent.
Co-authored-by: Anastasiya Mashoshyna <[email protected]>
Co-authored-by: Anastasiya Mashoshyna <[email protected]>
Co-authored-by: Anastasiya Mashoshyna <[email protected]>
Co-authored-by: Anastasiya Mashoshyna <[email protected]>
Co-authored-by: Anastasiya Mashoshyna <[email protected]>
Co-authored-by: Anastasiya Mashoshyna <[email protected]>
Co-authored-by: Anastasiya Mashoshyna <[email protected]>
Co-authored-by: Anastasiya Mashoshyna <[email protected]>
No description provided.