update pod status from leaf to root #730
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gao12312
force-pushed
the
develop
branch
3 times, most recently
from
0fe26e3
to
7de5842
Compare
OrangeBao
reviewed
Sep 30, 2024
pkg/clustertree/cluster-manager/controllers/node_lease_controller.go
Outdated
Show resolved
Hide resolved
OrangeBao
reviewed
Oct 9, 2024
| // } | ||
| // }) | ||
| // return reconcile.Result{}, nil | ||
| // } | ||
| func (r *LeafPodReconciler) Reconcile(ctx context.Context, request reconcile.Request) (reconcile.Result, error) { |
There was a problem hiding this comment.
Delete the annotated code above
OrangeBao
reviewed
Oct 9, 2024
| @@ -60,6 +60,7 @@ type ClusterController struct { | |||
| ControllerManagers map[string]manager.Manager | |||
| ManagerCancelFuncs map[string]*context.CancelFunc | |||
| ControllerManagersLock sync.Mutex | |||
| SharedPodLock sync.Mutex | |||
|
|
|||
There was a problem hiding this comment.
This lock has some issues.
…lict Signed-off-by: gaoyuan <[email protected]>
duanmengkk
reviewed
Oct 10, 2024
| @@ -307,6 +310,7 @@ func (c *ClusterController) setupControllers( | |||
| leafPodController := podcontrollers.LeafPodReconciler{ | |||
| RootClient: c.Root, | |||
| Namespace: "", | |||
| PodLock: &SharedPodLock, | |||
| } | |||
There was a problem hiding this comment.
The usage of the shared lock is incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What does this PR do?
update pod status from leaf to root
Which issue(s) does this PR fix?
Fixes #705
Special notes for your reviewer:
Does this PR introduce a user-facing change?