Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24.02 User Guide Update #43

Merged
merged 6 commits into from
Feb 25, 2024
Merged

24.02 User Guide Update #43

merged 6 commits into from
Feb 25, 2024

Conversation

offset-torque
Copy link
Contributor

@offset-torque offset-torque commented Feb 25, 2024

Changelog provided here: koreader/koreader#11147 (comment)


This change is Reviewable

Copy link

@offset-torque
Copy link
Contributor Author

Is there anything else I should do @Frenzie ?

@Frenzie
Copy link
Member

Frenzie commented Feb 25, 2024

Strange, the preview doesn't seem to be working. But no, this is all excellent.

@Frenzie Frenzie merged commit a6a1c3e into koreader:master Feb 25, 2024
2 checks passed
@Frenzie
Copy link
Member

Frenzie commented Feb 28, 2024

@offset-torque #45 might unfortunately make life a little bit more annoying for you, but it'll warn us in the PR if a change is at risk of breaking Weblate. Though as long as you allow edits by maintainers on a PR you can also ask me to take care of it before merging. ;-)

@offset-torque
Copy link
Contributor Author

Thanks for fixing it Frenzie. VS Code didn't show any problems and page rendered properly in the browser checks so I didn't notice it. No problem for me, I don't want to break Weblate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants