User guide: minor CSS fixes #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caught by validator. It's either the now outdated page-break-before: always or the newer break-before: page.
Frenzie
commented
Dec 3, 2023
| @@ -32,10 +32,10 @@ | |||
| color: #009788; | |||
| font-weight: bold; | |||
| text-decoration: none; | |||
| &:hover {color: #fa5750;} | |||
There was a problem hiding this comment.
And this is SASS, not CSS. ;-)
There was a problem hiding this comment.
Never heard of SASS :/
https://sass-lang.com/
Dunno if it's some preprocessor stuff and we get proper normal CSS at the end.
But if it's "broken" CSS that is supposed to have no effect on normal browsers, better be sure that they also have no effect with crengine, as I'm not sure I ever made sure it behave per-specs on unexpected input :)
There was a problem hiding this comment.
In this context it's invalid CSS, hence why I resolved it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught by validator. It's either the now outdated page-break-before: always or the newer break-before: page.
This change is