Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception being thrown on changelevel #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AnAkkk
Copy link

@AnAkkk AnAkkk commented May 11, 2015

This fixes the problem described in koraktor/steam-condenser#270

@koraktor
Copy link
Owner

Finally back at this problem…

Doesn’t this make the RCONTerminator workaround obsolete?

@AnAkkk
Copy link
Author

AnAkkk commented Jul 21, 2015

I don't think it would, the RCONTerminator will still be sent after a successful reply. It just won't throw the exception if there haven't been any reply.
I've been using this fix since I've posted it, and everything works fine, I haven't had any more issues.

@AnAkkk
Copy link
Author

AnAkkk commented Sep 8, 2015

FYI it's now even worse on Dota 2 Reborn (Source 2), Valve changed a bit the rcon code apparently, the workaround no longer works and steam condenser just throw a timeout exception every time as the server won't reply to the 2nd packet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants