[RFR]Update binary analysis test case (#1308)

Signed-off-by: Karishma Punwatkar <[email protected]> modified: cypress/e2e/tests/migration/applicationinventory/analysis/binary_analysis.test.ts modified: cypress/fixtures/analysis.json
konveyor · Jan 17, 2025 · f38f55b · f38f55b
1 parent 462924c
commit f38f55b
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 1 deletion.
diff --git a/cypress/e2e/tests/migration/applicationinventory/analysis/binary_analysis.test.ts b/cypress/e2e/tests/migration/applicationinventory/analysis/binary_analysis.test.ts
@@ -29,6 +29,7 @@ import { CredentialsSourceControlUsername } from "../../../../models/administrat
 import { CredentialsMaven } from "../../../../models/administration/credentials/credentialsMaven";
 import { MavenConfiguration } from "../../../../models/administration/repositories/maven";
 import { Application } from "../../../../models/migration/applicationinventory/application";
+import { AppIssue } from "../../../../types/types";
 let source_credential: CredentialsSourceControlUsername;
 let maven_credential: CredentialsMaven;
 const mavenConfiguration = new MavenConfiguration();
@@ -85,6 +86,12 @@ describe(["@tier1"], "Binary Analysis", () => {
         application.verifyAnalysisStatus(AnalysisStatuses.completed);
         Application.open(true);
         application.verifyEffort(this.analysisData["binary_analysis_on_tackletestapp"]["effort"]);
+        application.validateIssues(this.analysisData["binary_analysis_on_tackletestapp"]["issues"]);
+        this.analysisData["binary_analysis_on_tackletestapp"]["issues"].forEach(
+            (currentIssue: AppIssue) => {
+                application.validateAffected(currentIssue);
+            }
+        );
     });
 
     afterEach("Persist session", function () {

diff --git a/cypress/fixtures/analysis.json b/cypress/fixtures/analysis.json
@@ -961,7 +961,35 @@
         "source": "Binary",
         "target": ["Containerization"],
         "appName": "customers-tomcat-0.0.1-SNAPSHOT.war",
-        "effort": 1
+        "effort": 2,
+        "issues": [
+            {
+                "name": "File system - Java IO",
+                "category": "mandatory",
+                "sources": ["None"],
+                "targets": ["cloud-readiness"],
+                "effort": 1,
+                "totalEffort": 1,
+                "incidents": 1,
+                "affectedFiles": 1,
+                "ruleSet": "cloud-readiness",
+                "rule": "local-storage-00001",
+                "labels": ["konveyor.io/source", "storage"]
+            },
+            {
+                "name": "Hardcoded IP Address",
+                "category": "mandatory",
+                "sources": ["None"],
+                "targets": ["cloud-readiness"],
+                "effort": 1,
+                "totalEffort": 1,
+                "incidents": 1,
+                "affectedFiles": 1,
+                "ruleSet": "discovery-rules",
+                "rule": "hardcoded-ip-address",
+                "labels": ["discovery"]
+            }
+        ]
     },
 
     "uploadbinary_analysis_on_acmeair": {