feat: Add trim for all properties of the identify

konnectors · Jan 3, 2024 · 5ea3922 · 5ea3922
1 parent 0362c24
commit 5ea3922
Show file tree

Hide file tree

Showing 4 changed files with 151 additions and 4 deletions.
diff --git a/packages/cozy-clisk/src/launcher/saveIdentity.js b/packages/cozy-clisk/src/launcher/saveIdentity.js
@@ -52,7 +52,7 @@ export default async (contactOrIdentity, accountIdentifier, options) => {
     : { contact: contactOrIdentity }
   identity.identifier = accountIdentifier
 
-  identity.contact = formatIdentityContact(identity.contact)
+  identity.contact = trimProperties(formatIdentityContact(identity.contact))
 
   // Format contact if needed
   if (identity.contact.phone) {
@@ -172,3 +172,14 @@ export function formatIdentityContact(contactToFormat) {
   }
   return contact
 }
+
+export function trimProperties(obj) {
+  for (let key in obj) {
+    if (typeof obj[key] === 'string') {
+      obj[key] = obj[key].trim()
+    } else if (typeof obj[key] === 'object' && obj[key] !== null) {
+      trimProperties(obj[key])
+    }
+  }
+  return obj
+}
diff --git a/packages/cozy-clisk/src/launcher/saveIdentity.spec.js b/packages/cozy-clisk/src/launcher/saveIdentity.spec.js
@@ -1,4 +1,7 @@
-import saveIdentity, { formatIdentityContact } from './saveIdentity'
+import saveIdentity, {
+  formatIdentityContact,
+  trimProperties
+} from './saveIdentity'
 
 describe('saveIdentity', function () {
   const client = {
@@ -152,3 +155,63 @@ describe('formatIdentityContact', () => {
     expect(formattedContact).toEqual(expectedContact)
   })
 })
+
+describe('trimProperties', () => {
+  it('should trim all properties', () => {
+    const contact = {
+      address: [
+        {
+          city: ' CITY',
+          formattedAddress: '86 CHEMIN DES DAMES 01001 CITY ',
+          postCode: '01001',
+          street: {
+            streetName: ' DES DAMES',
+            streetNumber: 86,
+            streetType: 'CHEMIN'
+          }
+        }
+      ],
+      email: ' [email protected] ',
+      name: {
+        firstName: 'Chris',
+        fullName: 'Chris A',
+        lastName: 'A'
+      },
+      phoneNumber: [
+        {
+          number: ' 060606060606',
+          type: 'mobile'
+        }
+      ]
+    }
+
+    const expectedContact = {
+      address: [
+        {
+          city: 'CITY',
+          formattedAddress: '86 CHEMIN DES DAMES 01001 CITY',
+          postCode: '01001',
+          street: {
+            streetName: 'DES DAMES',
+            streetNumber: 86,
+            streetType: 'CHEMIN'
+          }
+        }
+      ],
+      email: '[email protected]',
+      name: {
+        firstName: 'Chris',
+        fullName: 'Chris A',
+        lastName: 'A'
+      },
+      phoneNumber: [
+        {
+          number: '060606060606',
+          type: 'mobile'
+        }
+      ]
+    }
+
+    expect(trimProperties(contact)).toEqual(expectedContact)
+  })
+})
diff --git a/packages/cozy-konnector-libs/src/libs/saveIdentity.js b/packages/cozy-konnector-libs/src/libs/saveIdentity.js
@@ -71,7 +71,7 @@ const saveIdentity = async (
     : { contact: contactOrIdentity }
   identity.identifier = accountIdentifier
 
-  identity.contact = formatIdentityContact(identity.contact)
+  identity.contact = trimProperties(formatIdentityContact(identity.contact))
   if (options.merge == false) {
     // Using cozy client in a none merging strategy here.
     const newClient = cozyClient.new
@@ -193,4 +193,16 @@ function formatIdentityContact(contactToFormat) {
   }
   return contact
 }
-module.exports = { saveIdentity, formatIdentityContact }
+
+function trimProperties(obj) {
+  for (let key in obj) {
+    if (typeof obj[key] === 'string') {
+      obj[key] = obj[key].trim()
+    } else if (typeof obj[key] === 'object' && obj[key] !== null) {
+      trimProperties(obj[key])
+    }
+  }
+  return obj
+}
+
+module.exports = { saveIdentity, formatIdentityContact, trimProperties }
diff --git a/packages/cozy-konnector-libs/src/libs/saveIdentity.spec.js b/packages/cozy-konnector-libs/src/libs/saveIdentity.spec.js
@@ -9,6 +9,7 @@ jest.mock('./cozyclient', () => ({
 const updateOrCreate = require('./updateOrCreate')
 const saveIdentity = require('./saveIdentity').saveIdentity
 const formatIdentityContact = require('./saveIdentity').formatIdentityContact
+const trimProperties = require('./saveIdentity').trimProperties
 const cozyClient = require('./cozyclient')
 
 describe('saveIdentity', () => {
@@ -132,3 +133,63 @@ describe('formatIdentityContact', () => {
     expect(formattedContact).toEqual(expectedContact)
   })
 })
+
+describe('trimProperties', () => {
+  it('should trim all properties', () => {
+    const contact = {
+      address: [
+        {
+          city: ' CITY',
+          formattedAddress: '86 CHEMIN DES DAMES 01001 CITY ',
+          postCode: '01001',
+          street: {
+            streetName: ' DES DAMES',
+            streetNumber: 86,
+            streetType: 'CHEMIN'
+          }
+        }
+      ],
+      email: ' [email protected] ',
+      name: {
+        firstName: 'Chris',
+        fullName: 'Chris A',
+        lastName: 'A'
+      },
+      phoneNumber: [
+        {
+          number: ' 060606060606',
+          type: 'mobile'
+        }
+      ]
+    }
+
+    const expectedContact = {
+      address: [
+        {
+          city: 'CITY',
+          formattedAddress: '86 CHEMIN DES DAMES 01001 CITY',
+          postCode: '01001',
+          street: {
+            streetName: 'DES DAMES',
+            streetNumber: 86,
+            streetType: 'CHEMIN'
+          }
+        }
+      ],
+      email: '[email protected]',
+      name: {
+        firstName: 'Chris',
+        fullName: 'Chris A',
+        lastName: 'A'
+      },
+      phoneNumber: [
+        {
+          number: '060606060606',
+          type: 'mobile'
+        }
+      ]
+    }
+
+    expect(trimProperties(contact)).toEqual(expectedContact)
+  })
+})