feat(RELEASE-1053): add support for final pipeline run

[seanconroy2021]

Added support for the final pipeline to run immediately after all other pipelines in the tenant workspace.
The final pipeline now receives references to the same resources as the tenant pipeline, including the Release resource.
A release is marked as failed if the final pipeline fails.

Jira: Release-1053

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[johnbieren]

PR looks quite good for a draft. I didn't review too closely as it is too hard to tell what your changes are since mine are also being shown until my PR is merged. One thing I will say though is that the PostActions thing is the finalPipeline. So anywhere you see PostActionsExecuted in like release_types.go or something, you can remove it

[johnbieren]

I didn't look at the release_types_test.go or adapter_test.go files until we get the code nailed down

[seanconroy2021]

I didn't look at the release_types_test.go or adapter_test.go files until we get the code nailed down

It all working now

[seanconroy2021]

/retest

[codecov]

Codecov Report

Attention: Patch coverage is 87.28324% with 22 lines in your changes missing coverage. Please review.

Project coverage is 84.13%. Comparing base (a70b506) to head (9fd591c).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
controllers/release/adapter.go	83.89%	10 Missing and 9 partials ⚠️
controllers/release/controller.go	0.00%	2 Missing ⚠️
loader/loader.go	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
+ Coverage   84.09%   84.13%   +0.04%     
==========================================
  Files          26       26              
  Lines        1635     1740     +105     
==========================================
+ Hits         1375     1464      +89     
- Misses        182      192      +10     
- Partials       78       84       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[theflockers]

I am only missing a Pipeline specific test, which is that the final Pipeline should not be passed alone. In case it is, it should fail.

Besides that, I see that the Tenant/Managed/Final pipeline testing might need improvement but this can be done later.

[seanconroy2021]

I am only missing a Pipeline specific test, which is that the final Pipeline should not be passed alone. In case it is, it should fail.

Besides that, I see that the Tenant/Managed/Final pipeline testing might need improvement but this can be done later.

Ok, so I have added the test in :

		It("should return false if only the Final Pipeline is set", func() {
			adapter.ctx = toolkit.GetMockedContext(ctx, []toolkit.MockData{
				{
					ContextKey: loader.ReleasePlanContextKey,
					Resource: &v1alpha1.ReleasePlan{
						ObjectMeta: metav1.ObjectMeta{
							Name:      "release-plan",
							Namespace: "default",
						},
						Spec: v1alpha1.ReleasePlanSpec{
							Application:            application.Name,
							ReleaseGracePeriodDays: 6,
							FinalPipeline:          parameterizedPipeline,
						},
					},
				},
			})
			result := adapter.validatePipelineDefined()
			Expect(result.Valid).To(BeFalse())
			Expect(result.Err).NotTo(HaveOccurred())
		})

[johnbieren]

@seanconroy2021 can you rebase this so we can merge it?

[openshift-ci]

New changes are detected. LGTM label has been removed.

[seanconroy2021]

@seanconroy2021 can you rebase this so we can merge it?

@johnbieren Are You happy to merge after the rebase, then ...

[johnbieren]

Yes, we have David's approval, and the only things that seem to have changed since mine are little nit picks. So let's merge it once it passes e2e. We'd like to have it in staging by a meeting tomorrow with UI

[johnbieren]

/retest