Skip to content

Conversation

@sadlerap
Copy link
Contributor

@sadlerap sadlerap commented Dec 8, 2025

GitHub appears to disallow SARIF uploads during runs triggered by merge_group events, so we can't unconditionally upload them. Predicate their uploads on non-merge_group events.

@snyk-io
Copy link

snyk-io bot commented Dec 8, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sadlerap sadlerap enabled auto-merge December 8, 2025 20:10
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.77%. Comparing base (f4852c6) to head (764a704).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #679   +/-   ##
=======================================
  Coverage   48.77%   48.77%           
=======================================
  Files          20       20           
  Lines        2688     2688           
=======================================
  Hits         1311     1311           
  Misses       1248     1248           
  Partials      129      129           
Flag Coverage Δ
unit-tests 48.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

GitHub appears to disallow SARIF uploads during runs triggered by
merge_group events, so we can't unconditionally upload them.  Predicate
their uploads on non-`merge_group` events.

Fixes: KFLUXINFRA-2629
Signed-off-by: Andy Sadler <[email protected]>
@sadlerap sadlerap force-pushed the ci-merge-queue-prep branch from d6ef5db to 764a704 Compare December 8, 2025 20:26
@sadlerap sadlerap added this pull request to the merge queue Dec 8, 2025
@sadlerap sadlerap removed this pull request from the merge queue due to a manual request Dec 8, 2025
@sadlerap sadlerap enabled auto-merge (squash) December 8, 2025 20:55
@gbenhaim
Copy link
Member

gbenhaim commented Dec 9, 2025

@sadlerap something doesn't work with the auto merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants