-
Notifications
You must be signed in to change notification settings - Fork 127
feat(KFLUXUI-883): add docs for pulling private image #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
🚀 Preview is available at: https://pr-540--konflux-docs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces valuable documentation for accessing private image repositories, which is a significant enhancement. The new accessing-private-images.adoc file clearly outlines steps for both UI-based login and creating service accounts for external systems. The imagerepository.adoc file has been updated to correctly reflect the default visibility and includes a helpful cross-reference to the new documentation. The changes generally adhere to the Konflux Docs Style Guide, particularly regarding the use of imperative mood and AsciiDoc formatting.
48f7b0c to
acc1071
Compare
|
🚀 Preview is available at: https://pr-540--konflux-docs.netlify.app |
|
I would ask the feature owner first to check whether the service account docs are what she expected. |
|
Example of pulling a private image quay.io/redhat-user-workloads-stage/yuzheng-tenant/devfile-sample-python-basic-a6c44:79fa211b96161b2340aebd6b487526069856ab5f with a user and a service account: Get token and loginFor a user, get a token from https://image-rbac-proxy.apps.stone-stage-p01.hpmt.p1.openshiftapps.com/oauth. For a service account, create a service-account-token for it. Pull imageNote
|
|
@MartinBasti @testcara Hope the last comment covers your questions. Let me know if I missed something. |
acc1071 to
593530c
Compare
|
🚀 Preview is available at: https://pr-540--konflux-docs.netlify.app |
|
@emilyzheng @MartinBasti PR has been refreshed based on latest questions and comments, Please help to review. Thank you. |
Thank you very much for your answers and adding those clarification notes into PR, it's clearer to me now. But we need to make it clear to any users to avoid many follow up questions on support. |
593530c to
89d8db7
Compare
|
🚀 Preview is available at: https://pr-540--konflux-docs.netlify.app |
|
I still miss updates I requested in the last comment |
89d8db7 to
725e989
Compare
|
🚀 Preview is available at: https://pr-540--konflux-docs.netlify.app |
|
@MartinBasti how about now? |
725e989 to
24c9c96
Compare
|
🚀 Preview is available at: https://pr-540--konflux-docs.netlify.app |
MartinBasti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Nice work <3
I am working for the feature KONFLUX-4978 and its refinement doc is here.
In the feature docs, we can see the user case about 'service account', so beside the UI usages, we also introduce the service account.