Update CODEOWNERS to include Hermeto team for prefetch#447
Update CODEOWNERS to include Hermeto team for prefetch#447ben-alkov wants to merge 2 commits intokonflux-ci:mainfrom
Conversation
Hermeto team needs to be notified when changes are made to this doc, so we can ensure that it stays accurate.
|
🚀 Preview is available at: https://pr-447--konflux-docs.netlify.app |
|
|
||
| # build | ||
| /modules/building/ @konflux-ci/build-maintainers | ||
| /modules/building/pages/prefetching-dependencies.adoc @ben-alkov |
There was a problem hiding this comment.
Having only one memeber in codeowners doesn't scale, it will require all the review from you only and block merging. I'd suggest to create a hermeto team and put the whole team here
There was a problem hiding this comment.
we can reuse hermeto team also in build definitions
There was a problem hiding this comment.
Can we simply use build-maintainers for the time being?
There was a problem hiding this comment.
If we do a larger group, I'll need to add in '.*rpm.*md' as well.
Q: Who is in build-maintainers?
There was a problem hiding this comment.
There was a problem hiding this comment.
Can we simply use build-maintainers for the time being?
I need to clarify what do you mean by this.
A) adding hermeto ppl into build maintainers?
- you will be notified about many things you may not care about
B) adding build-maintainers into /modules/building/pages/prefetching-dependencies.adoc
it's already there for the parent dir, so it should be inherited
There was a problem hiding this comment.
adding hermeto ppl into build maintainers?
- you will be notified about many things you may not care about
True.
adding build-maintainers into /modules/building/pages/prefetching-dependencies.adoc
it's already there for the parent dir, so it should be inherited
True, didn't notice it in the diff. This is still a draft and I don't think this is a critical change, so maybe we can setup a prefetch subteam in the GH org and then refresh this PR accordingly?
There was a problem hiding this comment.
so maybe we can setup a prefetch subteam in the GH org and then refresh this PR accordingly?
Yeah, this was Martin's idea of setting up a net-new Hermeto team for this, and also build-definitions.
ben-alkov
changed the title
Updated CODEOWNERS to change ownership of prefetching-dependencies.adoc to "prefetch" team
|
🚀 Preview is available at: https://pr-447--konflux-docs.netlify.app |
|
what's the status of this PR? |
|
closing due to inactivity |
3 participants
Hermeto team needs to be notified when changes are made to this file, so we can ensure that it stays accurate.