Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(KFLUXVNGD-155): Add custom certificate support for git clone and buildah task #1814

Merged
merged 1 commit into from
Jan 28, 2025
Merged

chore(KFLUXVNGD-155): Add custom certificate support for git clone and buildah task #1814

merged 1 commit into from
Jan 28, 2025

Conversation

hmariset
Copy link
Contributor

@hmariset hmariset commented Jan 13, 2025 •
edited
Loading

Add param to support the custom certificate support for git-clone-oci-ta and
buildah-oci-ta tasks to connect to internal registry. For this we have updated
the use-trusted-artifact/create-trusted-artifact steps, which download/upload
the artifact from/to a registry.

Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-155

@hmariset hmariset requested a review from avi-biton January 13, 2025 14:07
@hmariset hmariset requested a review from a team as a code owner January 13, 2025 14:07
@hmariset hmariset marked this pull request as draft January 13, 2025 14:20
@hmariset hmariset force-pushed the KFLUXVNGD-155 branch 5 times, most recently from 69d2738 to e4568e5 Compare January 15, 2025 16:53
@hmariset hmariset changed the title chore(KFLUXVNGD-148): Add custom certificate support for git clone task chore(KFLUXVNGD-155): Add custom certificate support for git clone task Jan 15, 2025
@hmariset hmariset marked this pull request as ready for review January 15, 2025 17:21
@hmariset hmariset force-pushed the KFLUXVNGD-155 branch 5 times, most recently from 9cdc9b9 to 57840dd Compare January 17, 2025 21:24
yftacherzog
yftacherzog previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@yftacherzog yftacherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hmariset
Copy link
Contributor Author

/retest

1 similar comment
@hmariset
Copy link
Contributor Author

/retest

@hmariset hmariset enabled auto-merge January 23, 2025 15:13
@hmariset
Copy link
Contributor Author

@konflux-ci/build-maintainers Please review this PR. Thank you!

chmeliik
chmeliik reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@chmeliik chmeliik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmariset could you describe the changes a bit better in the commit message?

My first thoughts when reviewing were:

Add custom certificate support for git clone task

Wait, it supports those already

Add param to support the custom certificate support for git-clone-oci-ta task to connect to internal registry.

Wait, why would the git-clone task connect to a registry? That was probably meant to say Gitlab?

Only later did I realize that this is for the use-trusted-artifact/create-trusted-artifact steps, which download/upload the artifact from/to a registry

@hmariset hmariset force-pushed the KFLUXVNGD-155 branch 2 times, most recently from 23630c6 to 30f3922 Compare January 27, 2025 15:04
@hmariset hmariset requested a review from chmeliik January 27, 2025 15:04
@hmariset
chore(KFLUXVNGD-148): Add custom certificate support for git clone an…
9e7ba7a 
…d buildah task

Add param to support the custom certificate support for git-clone-oci-ta and
buildah-oci-ta tasks to connect to internal registry. For this we have updated
the use-trusted-artifact/create-trusted-artifact steps, which download/upload
the artifact from/to a registry.

Jira-Url: https://issues.redhat.com/browse/KFLUXVNGD-155
Signed-off-by: Homaja Marisetty <[email protected]>
@hmariset hmariset changed the title chore(KFLUXVNGD-155): Add custom certificate support for git clone task chore(KFLUXVNGD-155): Add custom certificate support for git clone and buildah task Jan 27, 2025
@hmariset
Copy link
Contributor Author

/retest

1 similar comment
@hmariset
Copy link
Contributor Author

/retest

@chmeliik
Copy link
Contributor

Failed with "verify-enterprise-contract-run-krkfj" already exists, the server was not able to generate a unique name for the object

That's a rare one 💎

/retest

@chmeliik
Copy link
Contributor

Thanks for the fix!

dirgim
dirgim approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hmariset
Copy link
Contributor Author

/retest

2 similar comments
@hmariset
Copy link
Contributor Author

/retest

@hmariset
Copy link
Contributor Author

/retest

@hmariset hmariset added this pull request to the merge queue Jan 28, 2025
Merged via the queue into konflux-ci:main with commit 07c9092 Jan 28, 2025
16 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmeliik chmeliik chmeliik approved these changes

@dirgim dirgim dirgim approved these changes

@yftacherzog yftacherzog yftacherzog left review comments

@avi-biton avi-biton Awaiting requested review from avi-biton

@ralphbean ralphbean Awaiting requested review from ralphbean

@ligangty ligangty Awaiting requested review from ligangty

@yma96 yma96 Awaiting requested review from yma96

@cgwalters cgwalters Awaiting requested review from cgwalters

@kdudka kdudka Awaiting requested review from kdudka

@brunoapimentel brunoapimentel Awaiting requested review from brunoapimentel

@eskultety eskultety Awaiting requested review from eskultety

@taylormadore taylormadore Awaiting requested review from taylormadore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hmariset @yftacherzog @chmeliik @dirgim @openshift-merge-robot