Implement P3371 #293
Open
Implement P3371 #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for the implementation of P3371. It's OFF by default. Nothing currently uses the macro.
Change existing hermitian_matrix_rank_1_update overloads to be overwriting instead of unconditionally updating, and add updating hermitian_matrix_rank_1_update overloads. Guard changes with the appropriate macro, which by default is NOT defined. Add lots of tests to ensure coverage of all cases. Tests pass whether or not P3371 support is enabled.
Change existing symmetric_matrix_rank_1_update overloads to be overwriting instead of unconditionally updating, and add updating symmetric_matrix_rank_1_update overloads. Guard changes with the appropriate macro, which by default is NOT defined. Add lots of tests to ensure coverage of all cases. Tests pass whether or not P3371 support is enabled.
One could imagine 3 ways to make sure alpha is real: 1. constrain alpha to be a noncomplex number type, 2. impose a precondition that alpha has zero imaginary part, or 3. set alpha to _`real-if-needed`_`(alpha)`. This commit implements Option (3). This has the advantage of working just like how linalg makes the diagonal real.
The function wasn't tested before. If the option to enable P3371's changes is enabled, the new tests don't build.
Change existing matrix_rank_1_update overloads to be overwriting instead of unconditionally updating, and add updating matrix_rank_1_update overloads. Guard changes with the appropriate macro, which by default is NOT defined. Add lots of tests to ensure coverage of all cases. Tests pass whether or not P3371 support is enabled.
Change existing matrix_rank_1_update_c overloads to be overwriting instead of unconditionally updating, and add updating matrix_rank_1_update_c overloads. Guard changes with the appropriate macro, which by default is NOT defined. Add lots of tests to ensure coverage of all cases. Tests pass whether or not P3371 support is enabled.
|
|
…mplementation and testing for rank 2k
|
Looked through rank_1 implementations - looks ok |
That's totally on me -- I was prioritizing "passes the tests" over "code makes sense" ; - ) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix_rank_1_updatematrix_rank_1_update_csymmetric_matrix_rank_1_updatehermitian_matrix_rank_1_updatesymmetric_matrix_rank_2_updatehermitian_matrix_rank_2_updatesymmetric_matrix_rank_k_updatehermitian_matrix_rank_k_updatesymmetric_matrix_rank_2k_updatehermitian_matrix_rank_2k_update