CI: Enable warning flags #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmm0
reviewed
Jun 20, 2024
| - compiler_driver: icpx | ||
| compiler_prefix: /opt/intel/oneapi/compiler/latest/linux/bin | ||
| # To get new URL, look here: | ||
| # https://www.intel.com/content/www/us/en/developer/articles/tool/oneapi-standalone-components.html#inpage-nav-6-undefined | ||
| compiler_url: https://registrationcenter-download.intel.com/akdlm/IRC_NAS/ebf5d9aa-17a7-46a4-b5df-ace004227c0e/l_dpcpp-cpp-compiler_p_2023.2.1.8_offline.sh | ||
| cxx_flags_extra: "-DMDSPAN_USE_BRACKET_OPERATOR=0" | ||
| cxx_flags_extra: "-DMDSPAN_USE_BRACKET_OPERATOR=0 -Wno-c++17-attribute-extensions -Wno-gnu-zero-variadic-macro-arguments" | ||
| - enable_benchmark: ON |
There was a problem hiding this comment.
Won't switching to Debug affect the benchmark times? Maybe we should add build type to the matrix
There was a problem hiding this comment.
Are these benchmark times recorded anywhere? To me, it seems we really only test correctness in the CI.
crtrott
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the builds in
cmake.ymlare mostly fine with-Werror -Wall -Wextra -pedantic:RelWithDebInfosince that uses-DNDEBUGdisabling a lot of asserts. Since we want these asserts to trigger, I changed the build type toDebug.clangcomplains about-Wc++17-attribute-extensionswhen using[[maybe_unused]]which seems harmless.clangcomplains about using variadic macros with empty ellipsis via-Wno-gnu-zero-variadic-macro-argumentswhich also seems harmless