batched - dense: Testing and fixing Serial QR #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucbv
force-pushed
the
batched_QR_fixes
branch
2 times, most recently
from
94496d2 to
4bfb715
Compare
cwpearson
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Can any of these structs be moved to Impl while you're at it? e.g. SerialQR_FormQ_Internal. Or would you prefer to do that as a separate deprecating PR?
| } | ||
| #endif | ||
|
|
||
| // #if defined(KOKKOSKERNELS_INST_COMPLEX_FLOAT) |
There was a problem hiding this comment.
Leave an explanation for why this is disabled.
lucbv
force-pushed
the
batched_QR_fixes
branch
2 times, most recently
from
18fc349 to
b24686b
Compare
lucbv
force-pushed
the
batched_QR_fixes
branch
from
def21e7 to
2b4e03b
Compare
The serial QR algorithms does not have unit-tests and is failing for non square matrices. See issue kokkos#2328. This first commit fixes the issue with rectangular matrices and adds a basic test for that use case. Next will work on adding a test that exercises the interfaces on multiple matrices of different sizes within a parallel_for. Finally equivalent tests will be added for the square case as well. Fixing unused variable error It looks like the Left NoTranspose ApplyQ is not doing the correct thing. Will have a look at that next. Signed-off-by: Luc <[email protected]> Signed-off-by: Luc Berger-Vergiat <[email protected]>
We did not pass the stride of the work array to internal routines and we are not enforcing a contiguous memory allocation either so when using subviews to pass the work array, we run into troubles. Signed-off-by: Luc Berger-Vergiat <[email protected]>
lucbv
force-pushed
the
batched_QR_fixes
branch
from
2b4e03b to
f4dfbe9
Compare
Signed-off-by: Luc Berger-Vergiat <[email protected]>
After fixing the issue with the workspace utilization now looking at issues when the problem and batch sizes are increased. Signed-off-by: Luc Berger-Vergiat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serial QR algorithms does not have unit-tests and is failing for non square matrices. See issue #2328.
This first commit fixes the issue with rectangular matrices and adds a basic test for that use case.
Next will work on adding a test that exercises the interfaces on multiple matrices of different sizes within a parallel_for. Finally equivalent tests will be added for the square case as well.
Tasks: