-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document deprecation for Kokkos 4 #593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table does not render super well.
Did you consider alternative approaches, such gathering entries in subsections corresponding to 4.X minor versions and having some bullet list or whatnot with optionally notes for some entries
It might be enough to just link to the respective pull request for more information. |
No it's not. Even if our PRs systematically came with good descriptions which they don't, that would still put unnecessarily the burden on the user to figure things out. |
f7c580a
to
c2b4fcb
Compare
I also pushed a list approach. We can discuss tomorrow which one we want to go with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can go over the list together in a small committee to speed things up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found some minor things a while ago and forgot to submit
Co-authored-by: JBludau <[email protected]>
I gathered everything up to kokkos/kokkos@43a3019. We still need sort them in sections similar to what we are doing for Kokkos 3.