Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document deprecation for Kokkos 4 #593

Merged
merged 15 commits into from
Nov 25, 2024
Merged

Conversation

masterleinad
Copy link
Contributor

@masterleinad masterleinad commented Oct 31, 2024

I gathered everything up to kokkos/kokkos@43a3019. We still need sort them in sections similar to what we are doing for Kokkos 3.

Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table does not render super well.
Did you consider alternative approaches, such gathering entries in subsections corresponding to 4.X minor versions and having some bullet list or whatnot with optionally notes for some entries

@masterleinad
Copy link
Contributor Author

It might be enough to just link to the respective pull request for more information.

@dalg24
Copy link
Member

dalg24 commented Nov 5, 2024

It might be enough to just link to the respective pull request for more information.

No it's not. Even if our PRs systematically came with good descriptions which they don't, that would still put unnecessarily the burden on the user to figure things out.

@masterleinad
Copy link
Contributor Author

I also pushed a list approach. We can discuss tomorrow which one we want to go with.

@masterleinad masterleinad marked this pull request as ready for review November 12, 2024 18:16
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can go over the list together in a small committee to speed things up

docs/source/deprecation_page.rst Outdated Show resolved Hide resolved
docs/source/deprecation_page.rst Show resolved Hide resolved
docs/source/deprecation_page.rst Outdated Show resolved Hide resolved
docs/source/deprecation_page.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@JBludau JBludau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found some minor things a while ago and forgot to submit

docs/source/deprecation_page.rst Outdated Show resolved Hide resolved
docs/source/deprecation_page.rst Outdated Show resolved Hide resolved
@dalg24 dalg24 merged commit 6d2f2d0 into kokkos:main Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants