stdalgos (9/10): team-level API, and rst update for release 4.2 #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnrizzi
reviewed
Jun 9, 2023
fnrizzi
changed the title
This was referenced Aug 10, 2023
fnrizzi
changed the title
fnrizzi
changed the title
fnrizzi
changed the title
fnrizzi
force-pushed
the
std_teamlevel_p9of10
branch
from
4c91a4d to
49773a3
Compare
ajpowelsnl
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
@antoinemeyer5 , @fnrizzi , @crtrott -- fine to merge the updates, but in the future, we should make sure that example code is paste-able and immediately run-able (assuming compilers in place), vs. pseudo code
| using view_type = Kokkos::View<int*>; | ||
| view_type a("a", 15); | ||
| // fill a somehow | ||
|
|
There was a problem hiding this comment.
Suggested change
| //TODO: write a tiny loop populating a 1D Kokkos View with a single integer value |
|
|
||
| namespace KE = Kokkos::Experimental; | ||
| Kokkos::View<double*> a("a", 13); | ||
| // fill a somehow |
There was a problem hiding this comment.
Suggested change
| // fill a somehow | |
| // TODO: write a tiny loop populating a 1D Kokkos View with a single integer value |
|
|
||
| namespace KE = Kokkos::Experimental; | ||
| Kokkos::View<double*> a("a", 13); | ||
| // fill a somehow |
There was a problem hiding this comment.
Suggested change
| // fill a somehow | |
| //TODO: write a tiny loop populating a 1D Kokkos View with a single integer value |
crtrott
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add team-level API to and convert to rst the following algorithms:
NOTE: this follows the new structure for documenting the API, but does not use sphinx because the lack of properly aligning things make things quite unreadable.
Open individual html with Firefox (must be firefox or it won't display correctly)
Archive.zip