Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide KokkosComm::initialize/finalize #88

Closed
wants to merge 13 commits into from
Closed

Provide KokkosComm::initialize/finalize #88

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6167b91
feat(init/fini): add basic initialization and finalization
dssgabriel Jun 13, 2024
e055c01
test(init/fini): update tests with new initialization/finalization APIs
dssgabriel Jun 13, 2024
d098a72
docs(init/fini): add documentation + tiny fixes
dssgabriel Jun 14, 2024
0baa4ca
fix(init): remove checks for printing stuff
dssgabriel Jun 14, 2024
5c5ed7e
feat(init): let users provide their thread level + simplify signature
dssgabriel Jun 14, 2024
8987ce5
fix(init): fix tests to match new function prototype
dssgabriel Jun 14, 2024
a68902e
fix: only filter all `--kokkos-` flags + format
dssgabriel Jun 14, 2024
4868c87
docs(init): update with new prototypes
dssgabriel Jun 14, 2024
f3c838c
feat: add wrapper for `MPI_THREAD_*` support levels
dssgabriel Jun 14, 2024
cfdd01e
fix: revert filter on `--kokkos-*` to only filter `--kokkos-help` flags
dssgabriel Jun 14, 2024
ee700c6
fix: prevent overlap w/ `MPI_{Init,Finalize}` & `Kokkos::{initialize,…
dssgabriel Jun 14, 2024
cfefa4e
docs: clarify valid usage and document `ThreadSupportLevel` wrapper
dssgabriel Jun 14, 2024
d3b00de
fix: suggestion from Andrey Prokopenko (@aprokop)
dssgabriel Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/KokkosComm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ inline void initialize(int &argc, char *argv[], int mpi_required_thread_lvl) {
// Strip "--help" and "--kokkos-help" from the flags passed to Kokkos if we are not on rank 0 to prevent Kokkos
// from printing the help message multiple times.
if (0 != rank) {
auto *help_it = std::find_if(argv, argv + argc,
[](std::string_view const &x) { return x == "--help" || x == "--kokkos-help"; });
auto *help_it = std::find_if(
argv, argv + argc, [](std::string_view const &x) { return x.find("--kokkos-") != std::string_view::npos; });
if (help_it != argv + argc) {
std::swap(*help_it, *(argv + argc - 1));
--argc;
Expand All @@ -65,9 +65,7 @@ inline void initialize(int &argc, char *argv[], int mpi_required_thread_lvl) {
Kokkos::initialize(argc, argv);
}

inline void initialize(int &argc, char *argv[]) {
initialize(argc, argv, MPI_THREAD_MULTIPLE);
}
inline void initialize(int &argc, char *argv[]) { initialize(argc, argv, MPI_THREAD_MULTIPLE); }

inline void finalize() {
Kokkos::finalize();
Expand Down