Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add irecv wrapper in KokkosComm namespace #76

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Add irecv wrapper in KokkosComm namespace #76

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
339bd84
Add irecv wrapper in KokkosComm namespace
nicoleavans Jun 5, 2024
87c9043
removed errant '&'
nicoleavans Jun 6, 2024
7635444
Add ExecSpace parameter.
nicoleavans Jun 10, 2024
51a228e
add irecv to KokkosComm namespace
nicoleavans Jun 11, 2024
5e17145
Merge branch 'kokkos:develop' into pr
nicoleavans Jun 11, 2024
a9e03db
Added alltoall wrapper, revised RecvView variables to rv
nicoleavans Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/KokkosComm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include "KokkosComm_collective.hpp"
#include "KokkosComm_version.hpp"
#include "KokkosComm_isend.hpp"
#include "KokkosComm_irecv.hpp"
#include "KokkosComm_recv.hpp"
#include "KokkosComm_send.hpp"
#include "KokkosComm_concepts.hpp"
Expand All @@ -33,6 +34,11 @@ Req isend(const ExecSpace &space, const SendView &sv, int dest, int tag, MPI_Com
return Impl::isend<SendMode>(space, sv, dest, tag, comm);
}

template <KokkosView RecvView>
void irecv(RecvView &sv, int src, int tag, MPI_Comm comm, MPI_Request req) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use sv for the receiving view? I think it was previously clearer with rv instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to more closely match the recv wrapper in the file:

template <KokkosExecutionSpace ExecSpace, KokkosView RecvView>
void recv(const ExecSpace &space, RecvView &sv, int src, int tag, MPI_Comm comm) {
  return Impl::recv(space, sv, src, tag, comm);
}

I agree it is clearer, I can change it back.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can change the recv wrapper to RecvView &rv as well then 👍

return Impl::irecv(sv, src, tag, comm, req);
}

template <CommMode SendMode = CommMode::Default, KokkosExecutionSpace ExecSpace, KokkosView SendView>
void send(const ExecSpace &space, const SendView &sv, int dest, int tag, MPI_Comm comm) {
return Impl::send<SendMode>(space, sv, dest, tag, comm);
Expand Down
Loading