add AES-128-CFB mode and it's test code.#182
Open
jifanchn wants to merge 3 commits intokokke:masterfrom
Open
Conversation
wmjdgla
reviewed
Jan 6, 2022
aes.h
Outdated
Comment on lines
87
to
91
| #endif // #if defined(CTR) && (CTR == 1) | ||
| #endif // #if defined(CFB) && (CFB == 1) |
There was a problem hiding this comment.
Should revert to the original line since the #if is for CTR
|
In aes.h/c, the code guarded by |
Author
|
Already fixed |
lil-skelly
approved these changes
Sep 21, 2024
lil-skelly
left a comment
There was a problem hiding this comment.
I was looking for a CFB mode implementation, and thankfully, I found this.
The code looks well structured and seems functional, I don't see why this hasn't been merged yet. @kokke , perhaps you want to take a look at this.
provrb
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi kokke:
I write a small piece of code to support CFB mode.
I think the code style is quite like the CFB part.
And I generated the test sample by a small golang program and paste the results into test code.
May this is helpful to others.