fix(commands): make CommandManager.config indepedent from its scope.config #333
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommandManager.config 和 CommandManager.ctx.scope.config 在初始化时为同一值，这将导致 CommandManager.update() 先重写配置项后触发 ctx.scope.update()， 此时 ctx.scope.config 已经被修改，导致 internal/before-update 中无法区分是否改动。 而 ctx.scope.update() 中调用了 schema()， 因此后续并不会出现问题。因而此pr在初始化时强制让二者独立来避免此问题。
Hieuzest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommandManager.config 和 CommandManager.ctx.scope.config 在初始化时为同一值，这将导致 CommandManager.update() 先重写配置项后触发 ctx.scope.update()， 此时 ctx.scope.config 已经被修改，导致 internal/before-update 中无法区分是否改动。 而 ctx.scope.update() 中调用了 schema()， 因此后续并不会出现问题。因而此pr在初始化时强制让二者独立来避免此问题。