Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: proxy support for image sources #145

Merged
merged 5 commits into from
Mar 10, 2024
Merged

feat: proxy support for image sources #145

merged 5 commits into from
Mar 10, 2024

Conversation

MaikoTan
Copy link
Member

@MaikoTan MaikoTan commented Mar 9, 2024

No description provided.

@MaikoTan MaikoTan requested review from shigma and SaarChaffee March 9, 2024 10:37
@MaikoTan MaikoTan added this to the v1.2.0 milestone Mar 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024 •
edited
Loading

PR Health

Build ✅

Details 
yarn run v1.22.21
$ yakumo build
Done in 2.70s.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024

PR Health

Build ✅

Details 
yarn run v1.22.21
$ yakumo build
Done in 2.65s.

@SaarChaffee
Copy link
Member

SaarChaffee commented Mar 9, 2024 •
edited
Loading

[W] booru source danbooru request failed
[W] booru source gelbooru request failed
[E] booru source pixiv unknown error: get pixiv image failed: Error: Login failed with status code undefined undefined
[W] booru source sankaku request faile
[W] booru source lolibooru request failed
[W] booru source yande request failed

@MaikoTan
Copy link
Member Author

MaikoTan commented Mar 9, 2024

Uh?
image

@Lipraty
Copy link
Member

Lipraty commented Mar 9, 2024

开 debug 日志，应该有详细的原因

@SaarChaffee
Copy link
Member

[W] booru source konachan request failed with code 403 "<html lang="en-US"><title>Just a moment...</title>......"

@SaarChaffee
Copy link
Member

SaarChaffee commented Mar 9, 2024 •
edited
Loading 

2024-03-09 21:15:43 [D] booru Error: Client network socket disconnected before secure TLS connection was established
                            at connResetException (node:internal/errors:787:14)
                            at TLSSocket.onConnectEnd (node:_tls_wrap:1727:19)
                            at TLSSocket.emit (node:events:526:35)
                            at endReadableNT (node:internal/streams/readable:1589:12)
                            at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
2024-03-09 21:15:43 [D] booru TypeError: fetch failed
                            at Object.fetch (node:internal/deps/undici/undici:11730:11)
                            at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
                            at async [cordis.invoke] (D:\Desktop\GitHub\BOT\koishi-app\node_modules\undios\lib\index.cjs:186:19)
                            at SankakuComplexImageSource.get (d:\Desktop\GitHub\BOT\koishi-app\external\booru\packages\sankaku\src\index.ts:21:22)
                            at Proxy.get (d:\Desktop\GitHub\BOT\koishi-app\external\booru\packages\core\src\index.ts:65:22)
                            at Command.<anonymous> (d:\Desktop\GitHub\BOT\koishi-app\external\booru\packages\core\src\command.tsx:29:22)
                            at Array.<anonymous> (D:\Desktop\GitHub\BOT\koishi-app\node_modules\@koishijs\core\src\command\command.ts:287:14)
                            at Command.execute (D:\Desktop\GitHub\BOT\koishi-app\node_modules\@koishijs\core\src\command\command.ts:303:22)
                            at <anonymous> (D:\Desktop\GitHub\BOT\koishi-app\node_modules\@koishijs\core\src\session.ts:396:22)
                            at Proxy.withScope (D:\Desktop\GitHub\BOT\koishi-app\node_modules\@koishijs\core\src\session.ts:293:22)
shared.js:249
2024-03-09 21:15:43 [D] booru Error: fetch https://capi-v2.sankakucomplex.composts/?tags=+order:random&limit=1 failed
                            at D:\Desktop\GitHub\BOT\koishi-app\node_modules\undios\lib\index.cjs:187:23
                            at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
                            at async [cordis.invoke] (D:\Desktop\GitHub\BOT\koishi-app\node_modules\undios\lib\index.cjs:186:19)
                            at SankakuComplexImageSource.get (d:\Desktop\GitHub\BOT\koishi-app\external\booru\packages\sankaku\src\index.ts:21:22)
                            at Proxy.get (d:\Desktop\GitHub\BOT\koishi-app\external\booru\packages\core\src\index.ts:65:22)
                            at Command.<anonymous> (d:\Desktop\GitHub\BOT\koishi-app\external\booru\packages\core\src\command.tsx:29:22)
                            at Array.<anonymous> (D:\Desktop\GitHub\BOT\koishi-app\node_modules\@koishijs\core\src\command\command.ts:287:14)
                            at Command.execute (D:\Desktop\GitHub\BOT\koishi-app\node_modules\@koishijs\core\src\command\command.ts:303:22)
                            at <anonymous> (D:\Desktop\GitHub\BOT\koishi-app\node_modules\@koishijs\core\src\session.ts:396:22)
                            at Proxy.withScope (D:\Desktop\GitHub\BOT\koishi-app\node_modules\@koishijs\core\src\session.ts:293:22)

@SaarChaffee
Copy link
Member

Yande get a long RT.

@MaikoTan
Copy link
Member Author

MaikoTan commented Mar 9, 2024

Looks like we should use api key for requesting danbooru or sankaku instead of unauthorised requests.

@MaikoTan MaikoTan added this pull request to the merge queue Mar 10, 2024
Merged via the queue into main with commit bf97124 Mar 10, 2024
8 checks passed
@MaikoTan MaikoTan deleted the proxy branch March 10, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaarChaffee SaarChaffee SaarChaffee approved these changes

@shigma shigma Awaiting requested review from shigma

Assignees
No one assigned
Labels
🍰 feature
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MaikoTan @SaarChaffee @Lipraty