Feat: chat regenerate and proceed #26
Conversation
|
The commands to trigger |
src/api.ts
Outdated
| @@ -46,13 +46,13 @@ class ChatGPT { | |||
| * @param message - The plaintext message to send. | |||
| * @param opts.conversationId - Optional ID of the previous message in a conversation | |||
| */ | |||
| async sendMessage(conversation: Conversation): Promise<Required<Conversation>> { | |||
| async sendMessage(conversation: Conversation, action: string): Promise<Required<Conversation>> { | |||
There was a problem hiding this comment.
| async sendMessage(conversation: Conversation, action: string): Promise<Required<Conversation>> { | |
| async sendMessage(conversation: Conversation, action: 'next' | 'variant' | 'continue'): Promise<Required<Conversation>> { |
Would be better for the typing
There was a problem hiding this comment.
And you can consider to put action into Conversation type as well.
There was a problem hiding this comment.
I don't think it's necessary. Because I think conversation represents the context of the chat, and I don't think action is part of the chat context, so I put it in the parameters of sendMessage.
| @@ -37,7 +37,7 @@ export const Config: Schema<Config> = Schema.intersect([ | |||
| }), | |||
| ]) | |||
|
|
|||
| const conversations = new Map<string, { messageId: string; conversationId: string }>() | |||
| const conversations = new Map<string, Conversation>() | |||
There was a problem hiding this comment.
Not really good to use type Conversation here, as we don't save messages in the map.
If you stick with a type, you can split them into two types, but I argue with that.
There was a problem hiding this comment.
What is your specific idea? My idea is to use the Conversation type here and save it in a Map. I can't think of any other idea at the moment.
There was a problem hiding this comment.
I think just to revert this type would be good to me.
Otherwise you should write something like:
export interface Conversation {
messageId: string
conversationId: string
}
export interface ConversationMessage extends Conversation {
message: string
}That would be much much redundant.
There was a problem hiding this comment.
So how do I save the chat context, which is necessary in the implementation of variant?
There was a problem hiding this comment.
Or
| const conversations = new Map<string, Conversation>() | |
| const conversations = new Map<string, Omit<Conversation, 'message'>>() |
while Omit is a built-in type of typescript.
Signed-off-by: Seidko <[email protected]>
|
The backend of OpenAI is really hard to deal with. 🤯 |
| @@ -37,7 +37,7 @@ export const Config: Schema<Config> = Schema.intersect([ | |||
| }), | |||
| ]) | |||
|
|
|||
| const conversations = new Map<string, { messageId: string; conversationId: string }>() | |||
| const conversations = new Map<string, Conversation>() | |||
There was a problem hiding this comment.
Or
| const conversations = new Map<string, Conversation>() | |
| const conversations = new Map<string, Omit<Conversation, 'message'>>() |
while Omit is a built-in type of typescript.
| let request: Conversation = conversations.get(key) | ||
| let action: ChatGPT.Action = input in actions ? actions[input] : 'next' |
There was a problem hiding this comment.
Also always use const, unless you really really need to change it in runtime, otherwise keep it immutable.
|
Sorry 😂 I was concerned that ChatGPT might start charging in the future so I haven't planned to continue this PR. I don't know what Maiko thinks, I'd like to hear your opinion. |
|
Maiko thinks that we should make it usable at least even with a subscription. So may you continue working on this? |
|
Okay 🤣 I have to admit I'm a bit lazy to do it because the captcha is really annoying. I will try to continue this PR, but I don't sure whether I can make it well. |
|
I want to completely refactor this plugin, so there is no need to keep this PR open, so I'm closing it now. |
implements #22