-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove state number limit #58
base: master
Are you sure you want to change the base?
Conversation
Please merge the updates!! I'm using this stepProgressBar in my project, but i need 6 step instead of 5, so these commits solve my problem. I can't insert the entire project with the changes in mine, i need a simple implementation, like this: (implementation 'com.kofigyan.stateprogressbar:stateprogressbar:1.0.0') in my dependencies. Really please, this is the fifth library that i use for make a stepProgressBar and this is the only one that work as i want. |
@adrien1018 if you make the artifact of your master-SNAPSHOT i can implement your library with this implementation (implementation 'com.github.adrien1018:StateProgressBar:master-SNAPSHOT') using jitpack.io . Tell me if you can/want 👍 |
@DalCreeper It turned out that jitpack was not working due to missing gradlew. Artifact is now built. |
@adrien1018 Man, THANK YOU!!! Now it works perfectly! Kotlin code:import androidx.appcompat.app.AppCompatActivity class MainActivity : AppCompatActivity() {
} XML code:
If you take a look on the code that i wrote above, you'll see that for make a simple modify about the maxNumberState you have to use the recreate() to adjust the entire stateProgressBar in the linearLayout, if you find a easier way to fix it automatically would be a cool feature to insert! |
hi did you merge these changes i also want to use |
@safiyaAkhtarDev you can obtain these changes with this dependencies: |
it is saying not found in Gradle, once can you check and let me know
…On Thu, 25 Mar 2021 at 18:32, DalCreeper ***@***.***> wrote:
@safiyaAkhtarDev <https://github.com/safiyaAkhtarDev> you can obtain
these changes with this dependencies:
implementation 'com.github.adrien1018:StateProgressBar:52cd5e85be'
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASD3533P5UVWXDI5TH3IQ4DTFMX45ANCNFSM4YAF4K3A>
.
|
@safiyaAkhtarDev if that version doesn't work, you can check other version here: |
thank you so very very much, you are life saver
…On Thu, 25 Mar 2021 at 19:10, DalCreeper ***@***.***> wrote:
@safiyaAkhtarDev <https://github.com/safiyaAkhtarDev> if that version
doesn't work, you can check other version here:
https://jitpack.io/#adrien1018/StateProgressBar
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASD353YL6OUVYWXR4PE4CTTTFM4LHANCNFSM4YAF4K3A>
.
|
@DalCreeper The issue is now fixed. |
You're the number one my friend! Good job! |
README and the sample program are also updated.