-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump DNSControl to v4.1.0 #103
base: main
Are you sure you want to change the base?
Conversation
Awesome to see moving to the upstream container image! |
Upstream is now available via GitHub Container Registry eg: ghcr.io/stackexchange/dnscontrol:4.1.1 |
echo "$DNSCONTROL_CHECKSUM dnscontrol" | sha256sum -c - && \ | ||
chmod +x dnscontrol && \ | ||
mv dnscontrol /usr/local/bin/dnscontrol | ||
|
||
RUN ["dnscontrol", "version"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stackexchange/dnscontrol doesn't come with bash which is required for entrypoint.sh
. In my testing changing this run line to include an apk add
for bash fixes this.
RUN dnscontrol version && \
apk add --no-cache bash
@koenrh any indication on when this might land? |
Any news on this?
|
I did not want to wait so I forked this repo to https://github.com/jauderho/dnscontrol-action Here's the difference (note the different container image): main...jauderho:dnscontrol-action:main Dockerfile is located here: https://github.com/jauderho/dockerfiles/blob/main/dnscontrol/Dockerfile This will now always use the latest version of dnscontrol. Carefully review before any usage. YMMV. |
No description provided.