Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair SecureSocketConnector #9

Merged
merged 1 commit into from
Nov 29, 2016
Merged

Repair SecureSocketConnector #9

merged 1 commit into from
Nov 29, 2016

Conversation

hanzi
Copy link
Contributor

@hanzi hanzi commented Nov 28, 2016

The $host parameter has not been handled correctly, so using this Connector would always fail for lack of a host name.

@mindplay-dk mindplay-dk merged commit 8992eaf into kodus:master Nov 29, 2016
@mindplay-dk
Copy link
Collaborator

Thanks! 👍

FYI, SecureSocketConnector is currently untested, per #7 - did it work for you with this patch in place?

@hanzi
Copy link
Contributor Author

hanzi commented Nov 29, 2016

It didn’t, but that was due to a problem with my mail server. Will give it another try when that’s resolved.

@hanzi
Copy link
Contributor Author

hanzi commented Nov 29, 2016

Yes, it worked well with GMail and another server of mine.

@hanzi hanzi deleted the secure-socket-connector-fix branch November 29, 2016 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanzi @mindplay-dk