Suppress SC2319/SC2320 when $? is assigned to a variable#3488
Open
ayushi-work wants to merge 1 commit into
Open
Suppress SC2319/SC2320 when $? is assigned to a variable#3488ayushi-work wants to merge 1 commit into
ayushi-work wants to merge 1 commit into
Conversation
Author
|
Hi @koalaman, just bumping this up! |
e-kwsm
requested changes
Jun 23, 2026
f2af3dc to
bc5cded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3486
SC2319 warns "This
$?refers to a condition, not a command. Assign to a variable to avoid it being overwritten." However, it fired even when$?was already being assigned to a variable via||or&&, like:The user is already following the advice (assigning to a variable), so the warning is a false positive.
This change skips both SC2319 and SC2320 when
$?appears inside aT_Assignmentnode.Test plan
cabal testpasses (all existing + 3 newprop_tests)exit $?after a condition still trigger SC2319