Add --exclude-from=FILE flag with default to .shellcheckignore#3485
Open
kantum wants to merge 5 commits into
Open
Add --exclude-from=FILE flag with default to .shellcheckignore#3485kantum wants to merge 5 commits into
kantum wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've said I'll do it, so here it is.
Disclaimer, I'm not a Haskell Developer™, this has been done with the help of you know who.
Should fix #1996 #2011 #2258 #2411 #2859
To be clarified:
It adds the Glob dependency, which I'm sure is not of the taste of everyone, suggestions are welcome.
I wanted to add tests but it made the diff less readable, let me know if you think it's needed.
I don't know the impact in term of performance, if someone has a test in mind let me know.
I know that
.shellcheckignoreis not what everyone wants, but it has very little chance to conflict with anything so I made it default, can still remove it if really unwanted.