allow image resource to configure exact repo #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
approved these changes
Dec 17, 2022
| if opts.koDockerRepo == "" && opts.imageRepo == "" { | ||
| return "", errors.New("one of KO_DOCKER_REPO env var, or provider `docker_repo` or `repo`, or image resource `repo` must be set") | ||
| } | ||
| po := []publish.Option{publish.WithAuthFromKeychain(authn.DefaultKeychain)} |
There was a problem hiding this comment.
rando thought: should we make this use the helpers automatically?
I think we did it in ko itself, so it might be nice for parity.
There was a problem hiding this comment.
Yeah good call. I'll send a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress toward #37
With this change there are now three places you can configure the repo:
KO_DOCKER_REPOenv var and everything just works, you getko build -Pbehavior.repoordocker_repo(deprecated); this overrides (1), you getko build -Pbehavior.repo; this overrides (1) and (2), and you getko build --barebehavior.