Specify 'manualPush' in constructor instead of setter.

Signed-off-by: Squareys <[email protected]>
knime-ip · Sep 12, 2016 · 2bd9815 · 2bd9815
1 parent feeafa9
commit 2bd9815
Showing 1 changed file with 15 additions and 15 deletions.
diff --git a/org.knime.scijava.commands/src/org/knime/scijava/commands/module/DefaultNodeModule.java b/org.knime.scijava.commands/src/org/knime/scijava/commands/module/DefaultNodeModule.java
@@ -48,7 +48,7 @@ class DefaultNodeModule implements NodeModule {
 
     private final Map<ModuleItem<?>, DataType> outputMapping;
 
-    private final NodeModuleOutputChangedListener outputListener;
+    private NodeModuleOutputChangedListener outputListener;
 
     private final LogService logService;
 
@@ -78,7 +78,7 @@ public DefaultNodeModule(final Context context, final ModuleInfo info,
         this.inputMapping = inputMapping;
         this.outputMapping = outputMapping;
         this.module = ms.createModule(info);
-        this.outputListener = new NodeModuleOutputChangedListener();
+        this.outputListener = new NodeModuleOutputChangedListener(false);
         this.logService = new KNIMELogService(logger);
 
         preProcess(params);
@@ -109,9 +109,9 @@ private void preProcess(final Map<String, Object> params) {
                 /* MultiOutputListener */
                 final String name = item.getName();
 
+                outputListener = new NodeModuleOutputChangedListener(true);
                 module.setInput(name, outputListener);
                 module.resolveInput(name);
-                outputListener.enableManualPush(true);
             } else if (LogService.class.equals(item.getType())) {
                 /* LogService */
                 final String name = item.getName();
@@ -158,7 +158,18 @@ private class NodeModuleOutputChangedListener
         private CellOutput output;
 
         /* true if the modules handles pushes itself, false otherwise */
-        private boolean manualPush = false;
+        private final boolean manualPush;
+
+        /**
+         * Constructor.
+         *
+         * @param manualPush
+         *            if <code>true</code>, signals that the module handles
+         *            pushing rows.
+         */
+        public NodeModuleOutputChangedListener(final boolean manualPush) {
+            this.manualPush = manualPush;
+        }
 
         @Override
         public void notifyListener() {
@@ -213,16 +224,5 @@ public void flush() {
                 notifyListener();
             }
         }
-
-        /**
-         * Enable/Disable manual push.
-         *
-         * @param b
-         *            if <code>true</code>, signals that the module handles
-         *            pushing rows.
-         */
-        public void enableManualPush(final boolean b) {
-            manualPush = b;
-        }
     }
 }