prepare for PR against Nero's branch - #15
Open
kndclark wants to merge 9 commits into
Open
Conversation
Apply the fixes accumulated during NeroReflex/linux PR #1 review: - drop all remaining KEY_F18 references (capability + resume sweep); nothing can emit F18 since the 0xA8-to-0x00 rewrite landed - remove dead case 0xA8 in handle_ally_event (unreachable after the rewrite) and the unreachable return -ENODEV in ally_gamepad_send_packet - strip trailing whitespace, restore blank lines after asus_reset_resume/asus_probe, add missing newline at EOF Out-of-tree accommodations retained: local asus-wmi.h include, go_s LED name spoof for SteamOS Game Mode, two-arg kzalloc_obj for 6.18.
The Legion Go S effect-string TODO is factually outdated: monocolor/ breathe/chroma/rainbow are the canonical sysfs effect strings shared with the mainline hid-lenovo-go driver, not placeholder names awaiting an Asus rebrand. The asus-wmi.h include comment is reworded as a plain note since the local header is a permanent out-of-tree accommodation, not a pending action. The go_s LED-name TODO stays: it is genuinely gated on Valve shipping a native ASUS profile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.