Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional GH actions for knative.dev/reconciler-test #3464

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Aug 3, 2022

This PR knative-extensions/reconciler-test#368 is stuck
for downstream tests

/assign @kvmware

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2022
@krsna-m
Copy link
Contributor

krsna-m commented Aug 3, 2022

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2022
@pierDipi
Copy link
Member Author

pierDipi commented Aug 3, 2022

@kvmware can you approve, please?

@krsna-m
Copy link
Contributor

krsna-m commented Aug 3, 2022

/approve
sorry my bad

@knative-prow
Copy link

knative-prow bot commented Aug 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kvmware, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@knative-prow knative-prow bot merged commit 4b4a2f7 into knative:main Aug 3, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 3, 2022

@pierDipi: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file prow/config.yaml

In response to this:

This PR knative-extensions/reconciler-test#368 is stuck
for downstream tests

/assign @kvmware

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants