Skip to content

Conversation

dprotaso
Copy link
Member

  • Exclude autoscaling annotations from everything but the KPA
  • propagate annotation updates to the Pod Autoscaler

When creating child resources for a Revisino we now exclude
propagating autoscaling annotations. The exception is the KPA
for which we do propagate annotations.
@knative-prow knative-prow bot requested review from dsimansk, linkvt and skonto October 22, 2025 03:09
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 22, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2025
@dprotaso dprotaso changed the title Allow manual scaling of the Pod Autoscaler [wip] Allow manual scaling of the Pod Autoscaler Oct 22, 2025
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2025
@dprotaso dprotaso added this to the v1.20.0 milestone Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 76.31579% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.05%. Comparing base (54868c2) to head (6c3267f).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
pkg/testing/functional.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16186      +/-   ##
==========================================
- Coverage   80.08%   80.05%   -0.03%     
==========================================
  Files         214      214              
  Lines       16940    16949       +9     
==========================================
+ Hits        13566    13569       +3     
- Misses       3015     3018       +3     
- Partials      359      362       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

@dprotaso: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
istio-latest-no-mesh_serving_main 6c3267f link true /test istio-latest-no-mesh

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant