Skip to content

Conversation

linkvt
Copy link

@linkvt linkvt commented Oct 21, 2025

Hi,

related PR in networking: knative/networking#1093

Proposed Changes

  • Allow using Serve mode with system-internal-tls
    • right now Proxy mode is always forced when using system-internal-tls
    • we should allow disabling this behavior as some ingresses support validating certificates with multiple SANs and do not need to hop over the activator

Release Note

Allow using Serve mode when using system-internal-tls

Questions:

  1. Should this change result in a docs change, even if I marked it as alpha flag for now?

Thanks for the feedback!

/kind enhancement
/cc @Fedosin

When system-internal-tls is enabled, the KPA reconciler now checks the
SystemInternalTLSAllowServeMode flag to determine whether to use serve
mode or force proxy mode. This allows configurations where internal TLS
is enabled but serve mode is still desired.
@knative-prow knative-prow bot requested a review from Fedosin October 21, 2025 13:42
@knative-prow
Copy link

knative-prow bot commented Oct 21, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linkvt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.02%. Comparing base (1dc73ee) to head (98fda9c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16183      +/-   ##
==========================================
- Coverage   80.06%   80.02%   -0.05%     
==========================================
  Files         214      214              
  Lines       16940    16941       +1     
==========================================
- Hits        13563    13557       -6     
- Misses       3019     3023       +4     
- Partials      358      361       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant