Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-contour nightly #15691

Merged

Conversation

knative-automation
Copy link
Contributor

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-contour.yaml contour.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-contour/latest/$x > ${GITHUB_WORKSPACE}/./third_party/contour-latest/$x
done

Details:

bumping knative.dev/net-contour fff8ae0...20b53ed:
  > 20b53ed upgrade to latest dependencies (# 1156)
  > 70833f1 update linter settings to match knative/pkg (# 1155)

bumping knative.dev/net-contour fff8ae0...20b53ed:
  > 20b53ed upgrade to latest dependencies (# 1156)
  > 70833f1 update linter settings to match knative/pkg (# 1155)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation knative-automation force-pushed the update-nightly/net-contour branch from 904389e to 257c2dc Compare January 14, 2025 11:05
@knative-prow knative-prow bot requested a review from a team January 14, 2025 11:05
Copy link

knative-prow bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign salaboy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.81%. Comparing base (243e1ea) to head (257c2dc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15691      +/-   ##
==========================================
+ Coverage   80.80%   80.81%   +0.01%     
==========================================
  Files         222      222              
  Lines       18034    18034              
==========================================
+ Hits        14572    14574       +2     
+ Misses       3090     3089       -1     
+ Partials      372      371       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

/override "test (v1.30x, kourier-tls, runtime)"

Copy link

knative-prow bot commented Jan 14, 2025

@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • test (v1.30x, kourier-tls, runtime)

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • License Compliance
  • build-tests_serving_main
  • contour-latest_serving_main
  • contour-tls_serving_main
  • istio-latest-no-mesh-tls_serving_main
  • istio-latest-no-mesh_serving_main
  • style / Golang
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • test (v1.30.x, kourier-tls, runtime)
  • tide
  • unit-tests_serving_main
  • upgrade-tests_serving_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "test (v1.30x, kourier-tls, runtime)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto
Copy link
Contributor

skonto commented Jan 15, 2025

/override "test (v1.30.x, kourier-tls, runtime)"

Copy link

knative-prow bot commented Jan 15, 2025

@skonto: Overrode contexts on behalf of skonto: test (v1.30.x, kourier-tls, runtime)

In response to this:

/override "test (v1.30.x, kourier-tls, runtime)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit b484fa2 into knative:main Jan 15, 2025
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants