Fix all linter warnings #15684

dprotaso · 2025-01-13T03:47:46Z

Fixes: #14692

This should unblock PRs that are being gated on the linter checks

Changes are broken down by linter fix

… assigning pods to activator

knative-prow · 2025-01-13T03:47:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dprotaso]
~~pkg/apis/OWNERS~~ [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dprotaso · 2025-01-13T03:52:03Z

/assign @skonto

codecov · 2025-01-13T03:52:57Z

Codecov Report

Attention: Patch coverage is 84.02778% with 23 lines in your changes missing coverage. Please review.

Project coverage is 80.80%. Comparing base (c2f2b8b) to head (86b4390).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/schema-tweak/overrides.go	0.00%	5 Missing ⚠️
pkg/reconciler/route/route.go	16.66%	5 Missing ⚠️
cmd/activator/main.go	0.00%	2 Missing ⚠️
cmd/schema-tweak/main.go	0.00%	2 Missing ⚠️
pkg/queue/sharedmain/handlers.go	0.00%	2 Missing ⚠️
cmd/default-domain/main.go	0.00%	1 Missing ⚠️
pkg/activator/handler/concurrency_reporter.go	75.00%	1 Missing ⚠️
pkg/activator/net/lb_policy.go	50.00%	1 Missing ⚠️
pkg/autoscaler/statforwarder/leases.go	80.00%	1 Missing ⚠️
pkg/queue/sharedmain/servers.go	0.00%	1 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15684      +/-   ##
==========================================
- Coverage   80.81%   80.80%   -0.02%     
==========================================
  Files         222      222              
  Lines       18034    18025       -9     
==========================================
- Hits        14575    14565      -10     
  Misses       3089     3089              
- Partials      370      371       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dprotaso · 2025-01-13T13:19:40Z

kourier-tls
/retest

skonto · 2025-01-14T10:31:25Z

/retest

skonto · 2025-01-14T10:41:43Z

pkg/activator/net/throttler.go

@@ -309,7 +309,7 @@ func (rt *revisionThrottler) updateCapacity(backendCount int) {
 		assigned := rt.podTrackers
 		if rt.containerConcurrency > 0 {
 			rt.resetTrackers()
-			assigned = assignSlice(rt.podTrackers, ai, ac, rt.containerConcurrency)
+			assigned = assignSlice(rt.podTrackers, ai, ac)


For reference this is due to #14022.

skonto · 2025-01-14T10:55:12Z

pkg/reconciler/autoscaling/kpa/kpa_test.go

+	assertMetric(t, wantMetrics)
+}
+
+// We don't use metricstest.AssertMetrics because it doesn't filter resources properly


Should we open an issue to fix metricstest.AssertMetrics?

skonto · 2025-01-14T10:56:24Z

Cannot run kourier tls:

Run actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16
Downloading single artifact
Error: Unable to download artifact(s): Artifact not found for name: artifacts
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.

skonto · 2025-01-14T10:56:56Z

/lgtm
/aprove

skonto · 2025-01-14T10:57:19Z

/unhold

skonto · 2025-01-14T12:32:26Z

/override ?

knative-prow · 2025-01-14T12:32:30Z

@skonto: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

?

Only the following failed contexts/checkruns were expected:

EasyCLA
License Compliance
build-tests_serving_main
istio-latest-no-mesh-tls_serving_main
istio-latest-no-mesh_serving_main
style / suggester / github_actions
style / suggester / shell
test (v1.31.x, kourier-tls, runtime)
tide
unit-tests_serving_main
upgrade-tests_serving_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

skonto · 2025-01-14T12:33:06Z

/override "test (v1.31.x, kourier-tls, runtime)"

knative-prow · 2025-01-14T12:33:11Z

@skonto: Overrode contexts on behalf of skonto: test (v1.31.x, kourier-tls, runtime)

In response to this:

/override "test (v1.31.x, kourier-tls, runtime)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dprotaso added 30 commits January 10, 2025 23:00

add updated linter config

44db34c

fix whitespace linting

4bd06eb

fix usestdlibvars linter

3844255

fix lint wastedassign

cc2fd64

address unparam linter - container concurrency wasn't being used when…

8cc3257

… assigning pods to activator

fix tenv linter

e0cc35f

fix stylecheck linter

3cb7a71

fix staticheck linter

65009c6

fix perfsprint linter

b0ce4af

fix nosprintfhostport

c716660

f perfsprint

9afcee8

fix nolintlint - remove nolint directives that had no effect

8d648ec

fix noctx linter

ca7f5e3

fix gomodguard linter - drop uber atomic package

153a53b

fix nilerr linter

0d7e578

fix mirror linter

b26986f

fix loggercheck linter

a22fa3b

fix govet linter

7cdf82a

fix gosimple linter

74d8600

fix gosec linter

a06abbc

fix unconvert linter

a72a657

fix perfsprint linter

d2f37ed

fix errname linter

ff89cc0

fix errlint linter

3900cd3

fix bodyclose linter

85df3e0

fix canonicalheader linter

129b481

fix durationcheck linter

73166ef

fix copyloopvar linter

f052fba

fix fatcontext linter

663dd2e

fix gocritic-commentFormatting

c6b9012

dprotaso added 4 commits January 12, 2025 19:36

fix intrange linter

18ea7bd

fix prealloc linter

f8e8ba7

fix flakey kpa test

b6a3c38

fix gofumpt linter

86b4390

knative-prow bot requested review from izabelacg and skonto January 13, 2025 03:47

knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 13, 2025

dprotaso changed the title ~~Linter~~ Fix all Linter warnings Jan 13, 2025

dprotaso changed the title ~~Fix all Linter warnings~~ Fix all linter warnings Jan 13, 2025

knative-prow bot assigned skonto Jan 13, 2025

skonto reviewed Jan 14, 2025

View reviewed changes

knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 14, 2025

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2025

knative-prow bot merged commit 19b9a09 into knative:main Jan 14, 2025
68 of 69 checks passed

skonto mentioned this pull request Jan 21, 2025

Golang linter reports several issues kserve/kserve#4201

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix all linter warnings #15684

Fix all linter warnings #15684

dprotaso commented Jan 13, 2025 •

edited

Loading

knative-prow bot commented Jan 13, 2025

dprotaso commented Jan 13, 2025

codecov bot commented Jan 13, 2025 •

edited

Loading

dprotaso commented Jan 13, 2025

skonto commented Jan 14, 2025

skonto Jan 14, 2025

skonto Jan 14, 2025

skonto commented Jan 14, 2025 •

edited

Loading

skonto commented Jan 14, 2025 •

edited

Loading

skonto commented Jan 14, 2025

skonto commented Jan 14, 2025

knative-prow bot commented Jan 14, 2025

skonto commented Jan 14, 2025

knative-prow bot commented Jan 14, 2025

Fix all linter warnings #15684

Fix all linter warnings #15684

Conversation

dprotaso commented Jan 13, 2025 • edited Loading

knative-prow bot commented Jan 13, 2025

dprotaso commented Jan 13, 2025

codecov bot commented Jan 13, 2025 • edited Loading

Codecov Report

dprotaso commented Jan 13, 2025

skonto commented Jan 14, 2025

skonto Jan 14, 2025

Choose a reason for hiding this comment

skonto Jan 14, 2025

Choose a reason for hiding this comment

skonto commented Jan 14, 2025 • edited Loading

skonto commented Jan 14, 2025 • edited Loading

skonto commented Jan 14, 2025

skonto commented Jan 14, 2025

knative-prow bot commented Jan 14, 2025

skonto commented Jan 14, 2025

knative-prow bot commented Jan 14, 2025

dprotaso commented Jan 13, 2025 •

edited

Loading

codecov bot commented Jan 13, 2025 •

edited

Loading

skonto commented Jan 14, 2025 •

edited

Loading

skonto commented Jan 14, 2025 •

edited

Loading