Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement cluster-local-domain-tls in serving #14610

Merged
merged 10 commits into from
Jan 25, 2024
Prev Previous commit
Next Next commit
keep existing secret in upgrade/downgrade tests
ReToCode committed Jan 16, 2024
commit 44153978f31656d76040eec9b8c5915e7fb51c3b
11 changes: 11 additions & 0 deletions test/config/ytt/certmanager/kapp-secret-upgrade.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# this file is necessary for upgrade/downgrade tests
# as kapp deletes existing files, resulting in a different
# secret type (an immutable field) which causes an error.
apiVersion: v1
kind: Secret
metadata:
name: routing-serving-certs
namespace: knative-serving
labels:
serving-certs-ctrl: "data-plane-routing"
networking.internal.knative.dev/certificate-uid: "serving-certs"
1 change: 1 addition & 0 deletions test/e2e-common.sh
Original file line number Diff line number Diff line change
@@ -291,6 +291,7 @@ function install() {

YTT_FILES+=("${REPO_ROOT_DIR}/test/config/ytt/ingress/${ingress}")
YTT_FILES+=("${REPO_ROOT_DIR}/test/config/ytt/certmanager/kapp-order.yaml")
YTT_FILES+=("${REPO_ROOT_DIR}/test/config/ytt/certmanager/kapp-secret-upgrade.yaml")
YTT_FILES+=("${REPO_ROOT_DIR}/third_party/cert-manager-${CERT_MANAGER_VERSION}/cert-manager.yaml")
YTT_FILES+=("${REPO_ROOT_DIR}/third_party/cert-manager-${CERT_MANAGER_VERSION}/net-certmanager.yaml")