Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement cluster-local-domain-tls in serving #14610

Merged
merged 10 commits into from
Jan 25, 2024

Use a revision tracker to reconcile on KCerts

e04287b
Select commit
Loading
Failed to load commit list.
Merged

implement cluster-local-domain-tls in serving #14610

Use a revision tracker to reconcile on KCerts
e04287b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 25, 2024 in 0s

85.79% (target 80.00%)

View this Pull Request on Codecov

85.79% (target 80.00%)

Details

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (aa3fb05) 85.99% compared to head (e04287b) 85.79%.
Report is 29 commits behind head on main.

Files Patch % Lines
pkg/reconciler/revision/reconcile_resources.go 0.00% 29 Missing ⚠️
pkg/reconciler/route/route.go 69.44% 16 Missing and 6 partials ⚠️
pkg/reconciler/route/domains/domains.go 66.66% 4 Missing and 2 partials ⚠️
cmd/activator/main.go 0.00% 5 Missing ⚠️
pkg/reconciler/revision/revision.go 0.00% 5 Missing ⚠️
pkg/activator/certificate/cache.go 0.00% 4 Missing ⚠️
cmd/controller/main.go 0.00% 1 Missing ⚠️
pkg/reconciler/accessor/networking/certificate.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14610      +/-   ##
==========================================
- Coverage   85.99%   85.79%   -0.20%     
==========================================
  Files         197      198       +1     
  Lines       14950    15117     +167     
==========================================
+ Hits        12856    12970     +114     
- Misses       1781     1826      +45     
- Partials      313      321       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov