Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-certmanager nightly #14586

Merged

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Nov 2, 2023

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-certmanager.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-certmanager/latest/$x > ${GITHUB_WORKSPACE}/./third_party/cert-manager-latest/$x
done

Details:

bumping knative.dev/net-certmanager 61a36d1...3fee08a:
  > 3fee08a upgrade to latest dependencies (# 620)
  > 182e1c4 upgrade to latest dependencies (# 619)
  > e5d1e77 upgrade to latest dependencies (# 618)

@knative-automation knative-automation force-pushed the update-nightly/net-certmanager branch from 9e11cf0 to a3caa0f Compare November 2, 2023 11:05
@knative-prow knative-prow bot requested a review from a team November 2, 2023 11:05
@knative-prow knative-prow bot added area/networking size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e473c4a) 86.00% compared to head (80e320a) 86.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14586   +/-   ##
=======================================
  Coverage   86.00%   86.00%           
=======================================
  Files         197      197           
  Lines       14916    14916           
=======================================
  Hits        12828    12828           
  Misses       1778     1778           
  Partials      310      310           

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 2, 2023
@ReToCode
Copy link
Member

ReToCode commented Nov 2, 2023

/override "https_serving_main"

Copy link

knative-prow bot commented Nov 2, 2023

@ReToCode: Overrode contexts on behalf of ReToCode: https_serving_main

In response to this:

/override "https_serving_main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bumping knative.dev/net-certmanager 61a36d1...3fee08a:
  > 3fee08a upgrade to latest dependencies (# 620)
  > 182e1c4 upgrade to latest dependencies (# 619)
  > e5d1e77 upgrade to latest dependencies (# 618)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation knative-automation force-pushed the update-nightly/net-certmanager branch from a3caa0f to 80e320a Compare November 3, 2023 11:05
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2023
Copy link

knative-prow bot commented Nov 3, 2023

@knative-automation: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
https_serving_main 80e320a link false /test https

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nak3
Copy link
Contributor

nak3 commented Nov 6, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2023
Copy link

knative-prow bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 40008af into knative:main Nov 6, 2023
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants