Skip to content

Commit

Permalink
Disable probe tests for kourier tls runtime (#15702)
Browse files Browse the repository at this point in the history
* disable probe tests with kourier tls runtime

* remove exclude

* use the testflag
  • Loading branch information
skonto authored Jan 17, 2025
1 parent fe0e53f commit d4766be
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions .github/workflows/kind-e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,6 @@ jobs:
- test-suite: e2e
test-path: ./test/e2e

exclude:
# Disabled due to flakiness: https://github.com/knative/serving/issues/15697
- k8s-version: v1.30.x
ingress: kourier-tls
test-suite: runtime
- k8s-version: v1.31.x
ingress: kourier-tls
test-suite: runtime
env:
KIND: 1
INGRESS_CLASS: ${{ matrix.ingress-class || matrix.ingress }}.ingress.networking.knative.dev
Expand Down Expand Up @@ -218,13 +210,18 @@ jobs:
- name: Test ${{ matrix.test-suite }}
run: |
FEATURE_FLAGS="-enable-alpha -enable-beta"
if [[ "${{ matrix.ingress}}" == "kourier-tls" ]] && [[ "${{ matrix.test-suite }}" == "runtime" ]]; then
# Disabled due to flakiness: https://github.com/knative/serving/issues/15697
FEATURE_FLAGS="$FEATURE_FLAGS -disable-optional-api"
fi
gotestsum --format testname -- \
-race -count=1 -parallel=1 -tags=e2e \
-timeout=30m \
${{ matrix.test-path }} \
-skip-cleanup-on-fail \
-disable-logstream \
-enable-alpha -enable-beta \
$FEATURE_FLAGS \
--ingress-class=${{ matrix.ingress-class || matrix.ingress }}.ingress.networking.knative.dev \
${{ matrix.test-flags }}
Expand Down

0 comments on commit d4766be

Please sign in to comment.