Review improvements

knative · Jan 16, 2024 · a6c363f · a6c363f
1 parent 584fb6c
commit a6c363f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pkg/reconciler/revision/controller.go b/pkg/reconciler/revision/controller.go
@@ -136,6 +136,7 @@ func newControllerWithOptions(
 	}
 	deploymentInformer.Informer().AddEventHandler(handleMatchingControllers)
 	paInformer.Informer().AddEventHandler(handleMatchingControllers)
+	certificateInformer.Informer().AddEventHandler(handleMatchingControllers)
 
 	// We don't watch for changes to Image because we don't incorporate any of its
 	// properties into our own status and should work completely in the absence of

diff --git a/test/e2e/encryption.go b/test/e2e/encryption.go
@@ -73,7 +73,7 @@ func getCertificateClass(cm *corev1.ConfigMap) string {
 
 func getCertManagerCA(clients *test.Clients) (*corev1.Secret, error) {
 	var secret *corev1.Secret
-	err := wait.PollImmediate(test.PollInterval, test.PollTimeout, func() (bool, error) {
+	err := wait.PollUntilContextTimeout(context.Background(), test.PollInterval, test.PollTimeout, true, func(context.Context) (bool, error) {
 		caSecret, err := clients.KubeClient.CoreV1().Secrets(certManagerNamespace).Get(context.Background(), certManagerCASecret, metav1.GetOptions{})
 		if err != nil {
 			return false, err