Make webhook owner references not a controller (controller=false) #3255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We setup namespace as the owner of the webhooks in order to clean up instances where a user deletes the namespace. This has issues with ArgoCD which we've included a workaround. But an upcoming ArgoCD PR will handle owner references properly if it is not a 'controller=true' reference. This PR changes the owner reference to not be a controlling one. We still block owner deletion because that was the original intent of adding the owner reference.
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/XS
dprotaso
changed the title
|
/assign @aliok |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3255 +/- ##
==========================================
- Coverage 75.08% 75.06% -0.03%
==========================================
Files 187 187
Lines 10244 10247 +3
==========================================
Hits 7692 7692
- Misses 2313 2315 +2
- Partials 239 240 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
bump @aliok |
1 similar comment
|
bump @aliok |
|
/assign @dsimansk @nader-ziada |
|
bump @dsimansk @nader-ziada |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of knative/serving#15483
We setup namespace as the owner of the webhooks in order to clean up
instances where a user deletes the namespace.
This has issues with ArgoCD which we've included a workaround.
But an upcoming ArgoCD PR will handle owner references properly if
it is not a 'controller=true' reference.
This PR changes the owner reference to not be a controlling one.
We still block owner deletion because that was the original intent
of adding the owner reference.
With the incoming ArgoCD change then we'll want controller=false
to be used (argoproj/gitops-engine#501, argoproj/gitops-engine#771)