-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s min and deps to 1.30 #3124
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3124 +/- ##
=======================================
Coverage 78.29% 78.29%
=======================================
Files 191 191
Lines 11186 11186
=======================================
Hits 8758 8758
Misses 2162 2162
Partials 266 266 ☔ View full report in Codecov by Sentry. |
Downstream tests fail due to:
In that file there is:
We need to patch https://github.com/dprotaso/controller-tools/commits/knative/ to ignore empty values as when I set cc @dprotaso |
Changes